Repository navigation
Clarify Final Comment Period status in the core/README - #1979
Conversation
There was a problem hiding this comment.
Pull request overview
Clarifies the CAP lifecycle wording in core/README.md by making the Final Comment Period (FCP) explicitly indicate its intended disposition (Acceptance vs Rejection), reducing ambiguity in CAP statuses across the spec docs.
Changes:
- Replaces the ambiguous “FCP: [Acceptance/Rejection]” terminology with “Final Comment Period: [Acceptance/Rejection]” and clarifies the transition outcomes.
- Updates the CAP-0085 entry in
core/README.mdto use the new explicit FCP disposition. - Synchronizes CAP-0085’s preamble
Statusfield with the README index entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/README.md | Clarifies workflow/status terminology and updates CAP-0085’s indexed status to include intended FCP disposition. |
| core/cap-0085.md | Updates the CAP preamble Status to match the README’s explicit “Final Comment Period: Acceptance” status. |
|
I would just replace it with "Final Comment Period" as this is how we've been using in the past and how it's referenced in the document anyways |
Removed the disposition from the FCP status. Those will now have to be inferred from the discussion thread. |
anupsdf
changed the title
Pull request was converted to draft
|
This pull request is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed. |
1a7d1df to
fe09072
Compare
Add documenting the reason for rejection Copilot suggestion
fe09072 to
255f69a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
core/README.md:13
- The new status no longer records whether the FCP is headed toward acceptance or rejection, yet the transition below depends on that disposition. Since CAPs expose only a
Statusfield (and the proposal index likewise has only aStatuscolumn), a CAP markedFinal Comment Periodcannot communicate which outcome applies. Keep the disposition in the status value (for example,Final Comment Period: Acceptance/Final Comment Period: Rejection) or define a concrete field/location that must record it.
- **Final Comment Period** — A CAP that has entered a Final Comment Period with an
intended disposition of Acceptance or Rejection. After one week has passed, during which any new concerns should be
addressed, the CAP will move to **Accepted** or **Rejected** according to its intended
disposition, or go back into a **Draft** state.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
core/README.md:13
- Collapsing
FCP: AcceptanceandFCP: Rejectioninto one status removes the only machine-readable indication of the intended disposition. CAP preambles and the proposal index expose only aStatusvalue, while this workflow still requires readers to know whether the CAP is headed toward acceptance or rejection. Please retain distinct FCP status values, or define a mandatory disposition field and explain where it is recorded and synchronized.
- **Final Comment Period** — A CAP that has entered a Final Comment Period with an
intended disposition of Acceptance or Rejection. After one week has passed, during which any new concerns should be
addressed, the CAP will move to **Accepted** or **Rejected** according to its intended
disposition, or go back into a **Draft** state.
what
Clarify Final Comment Period: Acceptance or Rejection in the core/README.
why
To remove ambiguity around the status of CAPs.